Skip to content

Conversation

RalfJung
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2019
@RalfJung
Copy link
Member Author

(Almost) submodule-only, toolstate fix Cc @oli-obk
@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Dec 24, 2019

📌 Commit 04c740b has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Dec 24, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2019
@RalfJung
Copy link
Member Author

Looks like no job is running anyway, so...
@bors p=100

aidanhs added a commit to aidanhs/rust that referenced this pull request Dec 24, 2019
@bors
Copy link
Collaborator

bors commented Dec 24, 2019

⌛ Testing commit 04c740b with merge 918823fc25bf957286657d1839faf3cf034bb780...

@RalfJung
Copy link
Member Author

Oh lol, @aidanhs and me literally raced on this. ;)
Yielding to rollup.
@bors retry

@rust-highfive

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Dec 24, 2019

⌛ Testing commit 04c740b with merge 84d8f9d...

bors added a commit that referenced this pull request Dec 24, 2019
@aidanhs
Copy link
Member

aidanhs commented Dec 24, 2019

Eh, rollup failed, let's leave this to run.

@bors
Copy link
Collaborator

bors commented Dec 24, 2019

☀️ Test successful - checks-azure
Approved by: RalfJung
Pushing 84d8f9d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2019
@bors bors merged commit 04c740b into rust-lang:master Dec 24, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #67579!

Tested on commit 84d8f9d.
Direct link to PR: #67579

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Dec 24, 2019
Tested on commit rust-lang/rust@84d8f9d.
Direct link to PR: <rust-lang/rust#67579>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
@RalfJung RalfJung deleted the miri branch December 26, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants